folkslinux
/
mamba
mirror of https://github.com/mamba-org/mamba.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Allow creating environment with empty folder as target prefix (#3919)

This commit is contained in:
Nicola Soranzo 2025-05-13 17:12:06 +01:00 committed by GitHub
parent 5e0e879e0a
commit cadd3c9e06
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 37 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
libmamba/src/api/create.cpp
View File

@ -44,8 +44,19 @@ namespace mamba
{
if (ctx.prefix_params.target_prefix == ctx.prefix_params.root_prefix)
{
LOG_ERROR << "Overwriting root prefix is not permitted";
throw std::runtime_error("Aborting.");
const auto message = "Overwriting root prefix is not permitted - aborting.";
LOG_ERROR << message;
throw mamba_error(message, mamba_error_code::incorrect_usage);
}
else if (!fs::is_directory(ctx.prefix_params.target_prefix))
{
const auto message = "Target prefix already exists and is not a folder - aborting.";
LOG_ERROR << message;
throw mamba_error(message, mamba_error_code::incorrect_usage);
}
else if (fs::is_empty(ctx.prefix_params.target_prefix))
{
LOG_WARNING << "Using existing empty folder as target prefix";
}
else if (fs::exists(ctx.prefix_params.target_prefix / "conda-meta"))
{
@ -64,8 +75,9 @@ namespace mamba
}
else
{
LOG_ERROR << "Non-conda folder exists at prefix";
throw std::runtime_error("Aborting.");
const auto message = "Non-conda folder exists at prefix - aborting.";
LOG_ERROR << message;
throw mamba_error(message, mamba_error_code::incorrect_usage);
}
}
if (create_specs.empty())

21
micromamba/tests/test_create.py
View File

@ -246,6 +246,27 @@ def test_env_logging_overhead_regression(tmp_home, tmp_root_prefix, tmp_path):
assert res["success"]
@pytest.mark.parametrize("target_prefix", ("file", "empty_dir", "non_empty_dir"))
def test_existing_target_prefix(tmp_root_prefix, tmp_path, target_prefix):
p = tmp_path / "myenv"
expected_p = p.resolve()
cmd = ["-p", p]
if target_prefix == "file":
expected_p.touch()
else:
expected_p.mkdir()
if target_prefix == "non_empty_dir":
(expected_p / "foo").touch()
if target_prefix in ("file", "non_empty_dir"):
with pytest.raises(subprocess.CalledProcessError):
helpers.create(*cmd)
else:
helpers.create(*cmd)
assert (expected_p / "conda-meta").exists()
@pytest.mark.parametrize("shared_pkgs_dirs", [True], indirect=True)
@pytest.mark.parametrize("root_prefix_type", (None, "env_var", "cli"))
@pytest.mark.parametrize("target_is_root", (False, True))