louis_lifu
/
vscode
mirror of https://github.com/microsoft/vscode.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Do not check for navigator to detect web environment in built-in extensions (#251688) 

Do not check for navigator to detect web environment
This commit is contained in:
Jean Pierre 2025-06-18 11:37:42 +07:00 committed by GitHub
parent 51eba2dc05
commit 0140ab3f1b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/simple-browser/src/extension.ts
View File

@ -87,5 +87,5 @@ export function activate(context: vscode.ExtensionContext) {
function isWeb(): boolean {
// @ts-expect-error
return typeof navigator !== 'undefined' && vscode.env.uiKind === vscode.UIKind.Web;
return !(typeof process === 'object' && !!process.versions.node) && vscode.env.uiKind === vscode.UIKind.Web;
}

3
extensions/typescript-language-features/src/utils/platform.ts
View File

@ -6,7 +6,7 @@
import * as vscode from 'vscode';
export function isWeb(): boolean {
return 'navigator' in globalThis && vscode.env.uiKind === vscode.UIKind.Web;
return !(typeof process === 'object' && !!process.versions.node) && vscode.env.uiKind === vscode.UIKind.Web;
}
export function isWebAndHasSharedArrayBuffers(): boolean {
@ -16,4 +16,3 @@ export function isWebAndHasSharedArrayBuffers(): boolean {
export function supportsReadableByteStreams(): boolean {
return isWeb() && 'ReadableByteStreamController' in globalThis;
}