louis_lifu
/
vscode
mirror of https://github.com/microsoft/vscode.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix #239574 (#239594)

This commit is contained in:
Sandeep Somavarapu 2025-02-04 13:21:12 +01:00 committed by GitHub
parent d0b83e6142
commit 4edc46abe1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/vs/platform/request/node/requestService.ts
View File

@ -201,8 +201,23 @@ export async function nodeRequest(options: NodeRequestOptions, token: Cancellati
req.on('error', reject);
// Handle timeout
if (options.timeout) {
req.setTimeout(options.timeout);
// Chromium network requests do not support the `timeout` option
if (options.isChromiumNetwork) {
// Use Node's setTimeout for Chromium network requests
const timeout = setTimeout(() => {
req.abort();
reject(new Error(`Request timeout after ${options.timeout}ms`));
}, options.timeout);
// Clear timeout when request completes
req.on('response', () => clearTimeout(timeout));
req.on('error', () => clearTimeout(timeout));
req.on('abort', () => clearTimeout(timeout));
} else {
req.setTimeout(options.timeout);
}
}
// Chromium will abort the request if forbidden headers are set.