mirrors
/
anolis-cloud-kernel
mirror of https://gitee.com/anolis/cloud-kernel.git
8
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
anolis-cloud-kernel/drivers/nfc
History
Zheng Wang 9888041ba4 nfc: st-nci: Fix use after free bug in ndlc_remove due to race condition 
ANBZ: #4781

commit 5000fe6c27 upstream.

This bug influences both st_nci_i2c_remove and st_nci_spi_remove.
Take st_nci_i2c_remove as an example.

In st_nci_i2c_probe, it called ndlc_probe and bound &ndlc->sm_work
with llt_ndlc_sm_work.

When it calls ndlc_recv or timeout handler, it will finally call
schedule_work to start the work.

When we call st_nci_i2c_remove to remove the driver, there
may be a sequence as follows:

Fix it by finishing the work before cleanup in ndlc_remove

CPU0                  CPU1

                    |llt_ndlc_sm_work
st_nci_i2c_remove   |
  ndlc_remove       |
     st_nci_remove  |
     nci_free_device|
     kfree(ndev)    |
//free ndlc->ndev   |
                    |llt_ndlc_rcv_queue
                    |nci_recv_frame
                    |//use ndlc->ndev

Fixes: 35630df68d ("NFC: st21nfcb: Add driver for STMicroelectronics ST21NFCB NFC chip")
Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20230312160837.2040857-1-zyytlz.wz@163.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

Fixes: CVE-2023-1990
Signed-off-by: Xiao Long <xiaolong@openanolis.org>
Reviewed-by: Xunlei Pang <xlpang@linux.alibaba.com>
Link: https://gitee.com/anolis/cloud-kernel/pulls/1579
 		2023-06-27 03:29:15 +00:00
..
fdp
…
microread
…
nfcmrvl nfc: nfcmrvl: Fix irq_of_parse_and_map() return value 2022-07-07 17:52:18 +02:00
nxp-nci NFC: nxp-nci: don't print header length mismatch on i2c error 2022-07-21 21:20:14 +02:00
pn533 nfc: pn533: Fix buggy cleanup order 2022-06-06 08:42:40 +02:00
pn544
…
s3fwrn5 nfc: s3fwrn5: Release the nfc firmware 2020-12-30 11:53:53 +01:00
st-nci nfc: st-nci: Fix use after free bug in ndlc_remove due to race condition 2023-06-27 03:29:15 +00:00
st21nfca nfc: st21nfca: fix incorrect sizing calculations in EVT_TRANSACTION 2022-06-14 18:32:46 +02:00
st95hf
…
Kconfig
…
Makefile
…
mei_phy.c
…
mei_phy.h
…
nfcsim.c nfc: nfcsim: fix use after free during module unload 2021-08-04 12:46:41 +02:00
port100.c NFC: port100: fix use-after-free in port100_send_complete 2022-03-16 14:15:59 +01:00
trf7970a.c
…