tipc: fix memory leak in tipc_link_xmit
[ Upstream commit69ae94725f
] In case the backlog transmit queue for system-importance messages is overloaded, tipc_link_xmit() returns -ENOBUFS but the skb list is not purged. This leads to memory leak and failure when a skb is allocated. This commit fixes this issue by purging the skb list before tipc_link_xmit() returns. Fixes:365ad353c2
("tipc: reduce risk of user starvation during link congestion") Signed-off-by: Tung Nguyen <tung.quang.nguyen@est.tech> Link: https://patch.msgid.link/20250403092431.514063-1-tung.quang.nguyen@est.tech Signed-off-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org> (cherry picked from commit 09c2dcda2c551bba30710c33f6ac678ae7395389)
This commit is contained in:
parent
0b4ead4029
commit
4351b1b41c
|
@ -1068,6 +1068,7 @@ int tipc_link_xmit(struct tipc_link *l, struct sk_buff_head *list,
|
|||
if (unlikely(l->backlog[imp].len >= l->backlog[imp].limit)) {
|
||||
if (imp == TIPC_SYSTEM_IMPORTANCE) {
|
||||
pr_warn("%s<%s>, link overflow", link_rst_msg, l->name);
|
||||
__skb_queue_purge(list);
|
||||
return -ENOBUFS;
|
||||
}
|
||||
rc = link_schedule_user(l, hdr);
|
||||
|
|
Loading…
Reference in New Issue