terapines
/
circt
mirror of https://github.com/llvm/circt.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[Transforms][HierarchicalRunner] Run passes only on HWModuleOp (#8495) 

This avoids crash due to passes being scheduled on HWMouleExtern op
This commit is contained in:
Hideto Ueno 2025-05-19 22:54:18 -07:00 committed by GitHub
parent d5660dc552
commit cc25d8a174
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/Transforms/HierarchicalRunner.cpp
View File

@ -11,6 +11,7 @@
//
//===----------------------------------------------------------------------===//
#include "circt/Dialect/HW/HWOps.h"
#include "circt/Support/InstanceGraph.h"
#include "circt/Transforms/Passes.h"
#include "mlir/IR/Operation.h"
@ -88,7 +89,7 @@ void HierarchicalRunnerPass::runOnOperation() {
auto *node = worklist.pop_back_val();
assert(node && "node should not be null");
auto op = node->getModule();
if (!op || !visited.insert(op))
if (!isa_and_nonnull<hw::HWModuleOp>(op) || !visited.insert(op))
continue;
// Ensure an analysis manager has been constructed for each of the nodes.

4
test/Transforms/hierarchical_runner.mlir
View File

@ -11,10 +11,14 @@ hw.module @bound(out out: i8) {
hw.output %add : i8
}
// CHECK-LABEL: hw.module.extern @extern
hw.module.extern @extern()
// CHECK-LABEL: hw.module @top
hw.module @top(out out: i8) {
%c1_i8 = hw.constant 1 : i8
%add = comb.add %c1_i8, %c1_i8 : i8
hw.instance "extern" @extern() -> ()
%0 = hw.instance "child" @child() -> (out: i8)
// CHECK: hw.output %c2_i8
hw.output %add : i8