wangtao
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[ELF] Replace two addSymbol() call sites with Symbol::resolve(). NFC 

If we have a handle of the symbol, insert() called by addSymbol() is
redundant. Just call resolve().

llvm-svn: 361802
This commit is contained in:
Fangrui Song 2019-05-28 10:12:06 +00:00
parent f57bd6bd23
commit 173a68f1fb
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lld/ELF/Writer.cpp
View File

@ -180,9 +180,9 @@ static Defined *addOptionalRegular(StringRef Name, SectionBase *Sec,
if (!S || S->isDefined())
return nullptr;
return cast<Defined>(Symtab->addSymbol(
Defined{/*File=*/nullptr, Name, Binding, StOther, STT_NOTYPE, Val,
/*Size=*/0, Sec}));
S->resolve(Defined{/*File=*/nullptr, Name, Binding, StOther, STT_NOTYPE, Val,
/*Size=*/0, Sec});
return cast<Defined>(S);
}
static Defined *addAbsolute(StringRef Name) {
@ -239,9 +239,8 @@ void elf::addReservedSymbols() {
if (Config->EMachine == EM_PPC || Config->EMachine == EM_PPC64)
GotOff = 0x8000;
Symtab->addSymbol(Defined{/*File=*/nullptr, GotSymName, STB_GLOBAL,
STV_HIDDEN, STT_NOTYPE, GotOff, /*Size=*/0,
Out::ElfHeader});
S->resolve(Defined{/*File=*/nullptr, GotSymName, STB_GLOBAL, STV_HIDDEN,
STT_NOTYPE, GotOff, /*Size=*/0, Out::ElfHeader});
ElfSym::GlobalOffsetTable = cast<Defined>(S);
}