wangtao
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[lldb] Quick Fix: IRExecutionUnit check pointer before access it 

Summary:
Move checking pointer code block before accessing the pointer
This caused lldb to crash when testing on Android

Patch by Wanyi Ye!

Differential Revision: https://reviews.llvm.org/D64434

llvm-svn: 365567
This commit is contained in:
Alex Langford 2019-07-09 22:24:54 +00:00
parent 14a4495155
commit 269b9f940f
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lldb/source/Expression/IRExecutionUnit.cpp
View File

@ -285,9 +285,6 @@ void IRExecutionUnit::GetRunnableInfo(Status &error, lldb::addr_t &func_addr,
m_execution_engine_up.reset(builder.create(target_machine)); m_execution_engine_up.reset(builder.create(target_machine));
m_strip_underscore =
(m_execution_engine_up->getDataLayout().getGlobalPrefix() == '_');
if (!m_execution_engine_up) { if (!m_execution_engine_up) {
error.SetErrorToGenericError(); error.SetErrorToGenericError();
error.SetErrorStringWithFormat("Couldn't JIT the function: %s", error.SetErrorStringWithFormat("Couldn't JIT the function: %s",
@ -295,6 +292,9 @@ void IRExecutionUnit::GetRunnableInfo(Status &error, lldb::addr_t &func_addr,
return; return;
} }
m_strip_underscore =
(m_execution_engine_up->getDataLayout().getGlobalPrefix() == '_');
class ObjectDumper : public llvm::ObjectCache { class ObjectDumper : public llvm::ObjectCache {
public: public:
void notifyObjectCompiled(const llvm::Module *module, void notifyObjectCompiled(const llvm::Module *module,