From 4f1f253ce509ebc20e1f7a2d8bb6885366b155f2 Mon Sep 17 00:00:00 2001 From: Davide Italiano Date: Tue, 30 Jun 2020 12:47:56 -0700 Subject: [PATCH] [TestReturnValue] Skip based on architecutre, not platform. --- lldb/packages/Python/lldbsuite/test/decorators.py | 5 +++-- .../test/API/functionalities/return-value/TestReturnValue.py | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/lldb/packages/Python/lldbsuite/test/decorators.py b/lldb/packages/Python/lldbsuite/test/decorators.py index 0ef2f931542c..ec084184cd65 100644 --- a/lldb/packages/Python/lldbsuite/test/decorators.py +++ b/lldb/packages/Python/lldbsuite/test/decorators.py @@ -411,14 +411,15 @@ def expectedFailureOS( debug_info=debug_info) -def expectedFailureDarwin(bugnumber=None, compilers=None, debug_info=None): +def expectedFailureDarwin(bugnumber=None, compilers=None, debug_info=None, archs=None): # For legacy reasons, we support both "darwin" and "macosx" as OS X # triples. return expectedFailureOS( lldbplatform.darwin_all, bugnumber, compilers, - debug_info=debug_info) + debug_info=debug_info, + archs=archs) def expectedFailureAndroid(bugnumber=None, api_levels=None, archs=None): diff --git a/lldb/test/API/functionalities/return-value/TestReturnValue.py b/lldb/test/API/functionalities/return-value/TestReturnValue.py index 24aa504a593c..08293ca48b95 100644 --- a/lldb/test/API/functionalities/return-value/TestReturnValue.py +++ b/lldb/test/API/functionalities/return-value/TestReturnValue.py @@ -165,7 +165,7 @@ class ReturnValueTestCase(TestBase): archs=["i386"]) @expectedFailureAll(compiler=["gcc"], archs=["x86_64", "i386"]) @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778") - @skipIfDarwinEmbedded # ABIMacOSX_arm64 doesn't get structs this big correctly + @expectedFailureDarwin(archs=["arm64"]) # ABIMacOSX_arm64 doesn't get structs this big correctly def test_vector_values(self): self.build() exe = self.getBuildArtifact("a.out")