From 5811fd6cc45d0af6fc7eb714fa60bf8f1ef5e75f Mon Sep 17 00:00:00 2001 From: Fariborz Jahanian Date: Wed, 11 Apr 2012 23:57:12 +0000 Subject: [PATCH] modern objective-c translator. Fixes a mis-translation when of a __block struct object. // rdar://11230308 llvm-svn: 154566 --- clang/lib/Rewrite/RewriteModernObjC.cpp | 4 ++++ clang/test/Rewriter/rewrite-modern-block.mm | 18 ++++++++++++++++++ 2 files changed, 22 insertions(+) create mode 100644 clang/test/Rewriter/rewrite-modern-block.mm diff --git a/clang/lib/Rewrite/RewriteModernObjC.cpp b/clang/lib/Rewrite/RewriteModernObjC.cpp index fd433f88c2e9..fd621a2a5ccb 100644 --- a/clang/lib/Rewrite/RewriteModernObjC.cpp +++ b/clang/lib/Rewrite/RewriteModernObjC.cpp @@ -4812,6 +4812,10 @@ void RewriteModernObjC::RewriteByRefVar(VarDecl *ND) { // {0, &ND, some_flag, __size=sizeof(struct __Block_byref_ND), // initializer-if-any}; bool hasInit = (ND->getInit() != 0); + // FIXME. rewriter does not support __block c++ objects which + // require construction. + if (hasInit && dyn_cast(ND->getInit())) + hasInit = false; unsigned flags = 0; if (HasCopyAndDispose) flags |= BLOCK_HAS_COPY_DISPOSE; diff --git a/clang/test/Rewriter/rewrite-modern-block.mm b/clang/test/Rewriter/rewrite-modern-block.mm new file mode 100644 index 000000000000..c5231bfcebc6 --- /dev/null +++ b/clang/test/Rewriter/rewrite-modern-block.mm @@ -0,0 +1,18 @@ +// RUN: %clang_cc1 -x objective-c++ -fblocks -fms-extensions -rewrite-objc %s -o %t-rw.cpp +// RUN: %clang_cc1 -fsyntax-only -fblocks -Wno-address-of-temporary -D"Class=void*" -D"id=void*" -D"SEL=void*" -D"__declspec(X)=" %t-rw.cpp +// rdar://11230308 + +typedef struct { + char byte0; + char byte1; +} CFUUIDBytes; + +void x(void *); + +void y() { + __block CFUUIDBytes bytes; + + void (^bar)() = ^{ + x(&bytes); + }; +}