wangtao
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[ELF] Rename RF_PROGBITS_NOT_EXEC_OR_WRITE to RF_RODATA 

Post commit review at D48406

llvm-svn: 335743
This commit is contained in:
Fangrui Song 2018-06-27 15:56:32 +00:00
parent 1a1687f1bb
commit 65f35e4afc
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lld/ELF/Writer.cpp
View File

@ -701,7 +701,7 @@ enum RankFlags {
RF_WRITE = 1 << 15, RF_WRITE = 1 << 15,
RF_EXEC_WRITE = 1 << 14, RF_EXEC_WRITE = 1 << 14,
RF_EXEC = 1 << 13, RF_EXEC = 1 << 13,
RF_PROGBITS_NOT_EXEC_OR_WRITE = 1 << 12, RF_RODATA = 1 << 12,
RF_NON_TLS_BSS = 1 << 11, RF_NON_TLS_BSS = 1 << 11,
RF_NON_TLS_BSS_RO = 1 << 10, RF_NON_TLS_BSS_RO = 1 << 10,
RF_NOT_TLS = 1 << 9, RF_NOT_TLS = 1 << 9,
@ -755,15 +755,14 @@ static unsigned getSectionRank(const OutputSection *Sec) {
Rank |= RF_EXEC_WRITE; Rank |= RF_EXEC_WRITE;
else else
Rank |= RF_EXEC; Rank |= RF_EXEC;
} else { } else if (IsWrite) {
if (IsWrite) Rank |= RF_WRITE;
Rank |= RF_WRITE; } else if (Sec->Type == SHT_PROGBITS) {
// Make non-executable and non-writable PROGBITS sections (e.g .rodata // Make non-executable and non-writable PROGBITS sections (e.g .rodata
// .eh_frame) closer to .text . They likely contain PC or GOT relative // .eh_frame) closer to .text. They likely contain PC or GOT relative
// relocations and there could be relocation overflow if other huge sections // relocations and there could be relocation overflow if other huge sections
// (.dynstr .dynsym) were placed in between. // (.dynstr .dynsym) were placed in between.
else if (Sec->Type == SHT_PROGBITS) Rank |= RF_RODATA;
Rank |= RF_PROGBITS_NOT_EXEC_OR_WRITE;
} }
// If we got here we know that both A and B are in the same PT_LOAD. // If we got here we know that both A and B are in the same PT_LOAD.