Implement 'm' memory operand properly

llvm-svn: 83785

llvm/lib/Target/MSP430/MSP430ISelDAGToDAG.cpp

@@ -52,6 +52,10 @@ namespace {
       return "MSP430 DAG->DAG Pattern Instruction Selection";
     }
 
+    virtual bool
+    SelectInlineAsmMemoryOperand(const SDValue &Op, char ConstraintCode,
+                                 std::vector<SDValue> &OutOps);
+
     // Include the pieces autogenerated from the target description.
   #include "MSP430GenDAGISel.inc"
 
@@ -122,6 +126,22 @@ bool MSP430DAGToDAGISel::SelectAddr(SDValue Op, SDValue Addr,
 }
 
 
+bool MSP430DAGToDAGISel::
+SelectInlineAsmMemoryOperand(const SDValue &Op, char ConstraintCode,
+                             std::vector<SDValue> &OutOps) {
+  SDValue Op0, Op1;
+  switch (ConstraintCode) {
+  default: return true;
+  case 'm':   // memory
+    if (!SelectAddr(Op, Op, Op0, Op1))
+      return true;
+    break;
+  }
+
+  OutOps.push_back(Op0);
+  OutOps.push_back(Op1);
+  return false;
+}
 
 /// InstructionSelect - This callback is invoked by
 /// SelectionDAGISel when it has created a SelectionDAG for us to codegen.

llvm/test/CodeGen/MSP430/inline-asm.ll

@@ -1,16 +1,25 @@
 ; RUN: llc < %s
-; PR4778
 target datalayout = "e-p:16:8:8-i8:8:8-i16:8:8-i32:8:8"
 target triple = "msp430-generic-generic"
 
-define signext i8 @__nesc_atomic_start() nounwind {
+define void @imm() nounwind {
-entry:
+        call void asm sideeffect "bic\09$0,r2", "i"(i16 32) nounwind
-  %0 = tail call i16 asm sideeffect "mov    r2, $0", "=r"() nounwind ; <i16> [#uses=1]
+        ret void
-  %1 = trunc i16 %0 to i8                         ; <i8> [#uses=1]
+}
-  %and3 = lshr i8 %1, 3                           ; <i8> [#uses=1]
+
-  %conv1 = and i8 %and3, 1                        ; <i8> [#uses=1]
+define void @reg(i16 %a) nounwind {
-  tail call void asm sideeffect "dint", ""() nounwind
+        call void asm sideeffect "bic\09$0,r2", "r"(i16 %a) nounwind
-  tail call void asm sideeffect "nop", ""() nounwind
+        ret void
-  tail call void asm sideeffect "", "~{memory}"() nounwind
+}
-  ret i8 %conv1
+
+@foo = global i16 0, align 2
+
+define void @immmem() nounwind {
+        call void asm sideeffect "bic\09$0,r2", "i"(i16* getelementptr(i16* @foo, i32 1)) nounwind
+        ret void
+}
+
+define void @mem() nounwind {
+        call void asm sideeffect "bic\09$0,r2", "m"(i16* @foo) nounwind
+        ret void
 }