wangtao
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix APFloat assertion failure in IdempotentOperationChecker resulting in having 

an APFloat with different "float semantics" than the compared float literal.

llvm-svn: 108590
This commit is contained in:
Ted Kremenek 2010-07-17 00:40:32 +00:00
parent 83f250f005
commit 8b9fd890e3
2 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
clang/lib/Checker/IdempotentOperationChecker.cpp
View File

@ -515,10 +515,12 @@ bool IdempotentOperationChecker::containsOneConstant(const Stmt *S) {
if (IL && IL->getValue() == 1) if (IL && IL->getValue() == 1)
return true; return true;
const FloatingLiteral *FL = dyn_cast<FloatingLiteral>(S); if (const FloatingLiteral *FL = dyn_cast<FloatingLiteral>(S)) {
const llvm::APFloat one(1.0); const llvm::APFloat &val = FL->getValue();
if (FL && FL->getValue().compare(one) == llvm::APFloat::cmpEqual) const llvm::APFloat one(val.getSemantics(), 1);
return true; if (val.compare(one) == llvm::APFloat::cmpEqual)
return true;
}
for (Stmt::const_child_iterator I = S->child_begin(); I != S->child_end(); for (Stmt::const_child_iterator I = S->child_begin(); I != S->child_end();
++I) ++I)

6
clang/test/Analysis/idempotent-operations.c
View File

@ -3,6 +3,7 @@
// Basic tests // Basic tests
extern void test(int i); extern void test(int i);
extern void test_f(float f);
void basic() { void basic() {
int x = 10, zero = 0, one = 1; int x = 10, zero = 0, one = 1;
@ -50,3 +51,8 @@ void basic() {
test(zero << x); // expected-warning {{idempotent operation; the left operand is always 0}} test(zero << x); // expected-warning {{idempotent operation; the left operand is always 0}}
test(zero >> x); // expected-warning {{idempotent operation; the left operand is always 0}} test(zero >> x); // expected-warning {{idempotent operation; the left operand is always 0}}
} }
void floats(float x) {
test_f(x * 1.0); // no-warning
test_f(x * 1.0F); // no-warning
}