From 8f70a9f892db8f18277b0f5127d9063de237debc Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Sun, 4 Oct 2015 04:53:37 +0000 Subject: [PATCH] SourceRanges are small and trivially copyable, don't them by reference. NFC llvm-svn: 249258 --- clang-tools-extra/clang-modernize/LoopConvert/LoopActions.cpp | 2 +- clang-tools-extra/clang-tidy/utils/IncludeSorter.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/clang-tools-extra/clang-modernize/LoopConvert/LoopActions.cpp b/clang-tools-extra/clang-modernize/LoopConvert/LoopActions.cpp index 97c363d04681..e1420a373288 100644 --- a/clang-tools-extra/clang-modernize/LoopConvert/LoopActions.cpp +++ b/clang-tools-extra/clang-modernize/LoopConvert/LoopActions.cpp @@ -811,7 +811,7 @@ void LoopFixer::doConversion(ASTContext *Context, AliasVarIsRef = AliasVar->getType()->isReferenceType(); // We keep along the entire DeclStmt to keep the correct range here. - const SourceRange &ReplaceRange = AliasDecl->getSourceRange(); + SourceRange ReplaceRange = AliasDecl->getSourceRange(); std::string ReplacementText; if (AliasUseRequired) diff --git a/clang-tools-extra/clang-tidy/utils/IncludeSorter.cpp b/clang-tools-extra/clang-tidy/utils/IncludeSorter.cpp index d8c2602be888..2432f072dac6 100644 --- a/clang-tools-extra/clang-tidy/utils/IncludeSorter.cpp +++ b/clang-tools-extra/clang-tidy/utils/IncludeSorter.cpp @@ -243,11 +243,11 @@ std::vector IncludeSorter::GetEdits() { std::string CurrentText; std::vector Fixes; for (const auto &LineEdit : Edits) { - const SourceRange &EditRange = LineEdit.second.first; // If the current edit is on the next line after the previous edit, add it // to the current block edit. if (LineEdit.first == CurrentEndLine + 1 && CurrentRange.getBegin() != CurrentRange.getEnd()) { + SourceRange EditRange = LineEdit.second.first; if (EditRange.getBegin() != EditRange.getEnd()) { ++CurrentEndLine; CurrentRange.setEnd(EditRange.getEnd()); @@ -260,7 +260,7 @@ std::vector IncludeSorter::GetEdits() { } CurrentEndLine = LineEdit.first; - CurrentRange = EditRange; + CurrentRange = LineEdit.second.first; CurrentText = LineEdit.second.second; } }