wangtao
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix for bug 34510 - Minidump target does not resolve new symbols correctly 

Even though the content of the minidump does not change in a debugging session,
frames can't be indiscriminately be cached since modules and symbols can be
explicitly added after the minidump is loaded.

The fix is simple, just let the base Thread::ClearStackFrames() do its job.

submitted by amccarth on behalf of lemo

Bug: https://bugs.llvm.org/show_bug.cgi?id=34510

Differential Revision: https://reviews.llvm.org/D37527

llvm-svn: 312735
This commit is contained in:
Adrian McCarthy 2017-09-07 18:29:48 +00:00
parent 8af4e23d1e
commit 8fe23bc520
2 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lldb/source/Plugins/Process/minidump/ThreadMinidump.cpp
View File

@ -43,8 +43,6 @@ ThreadMinidump::~ThreadMinidump() {}
void ThreadMinidump::RefreshStateAfterStop() {} void ThreadMinidump::RefreshStateAfterStop() {}
void ThreadMinidump::ClearStackFrames() {}
RegisterContextSP ThreadMinidump::GetRegisterContext() { RegisterContextSP ThreadMinidump::GetRegisterContext() {
if (!m_reg_context_sp) { if (!m_reg_context_sp) {
m_reg_context_sp = CreateRegisterContextForFrame(nullptr); m_reg_context_sp = CreateRegisterContextForFrame(nullptr);

2
lldb/source/Plugins/Process/minidump/ThreadMinidump.h
View File

@ -37,8 +37,6 @@ public:
lldb::RegisterContextSP lldb::RegisterContextSP
CreateRegisterContextForFrame(StackFrame *frame) override; CreateRegisterContextForFrame(StackFrame *frame) override;
void ClearStackFrames() override;
protected: protected:
lldb::RegisterContextSP m_thread_reg_ctx_sp; lldb::RegisterContextSP m_thread_reg_ctx_sp;
llvm::ArrayRef<uint8_t> m_gpregset_data; llvm::ArrayRef<uint8_t> m_gpregset_data;