wangtao
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[X86] Add X86TargetLowering::isCommutativeBinOp override. 

We currently just have test coverage for PMULUDQ - will add more in the future.

llvm-svn: 357244
This commit is contained in:
Simon Pilgrim 2019-03-29 11:25:58 +00:00
parent 62f0d1650a
commit aeaf7fcdde
3 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
llvm/lib/Target/X86/X86ISelLowering.cpp
View File

@ -28018,6 +28018,16 @@ bool X86TargetLowering::isVectorShiftByScalarCheap(Type *Ty) const {
return true; return true;
} }
bool X86TargetLowering::isCommutativeBinOp(unsigned Opcode) const {
switch (Opcode) {
// TODO: Add more X86ISD opcodes once we have test coverage.
case X86ISD::PMULUDQ:
return true;
}
return TargetLoweringBase::isCommutativeBinOp(Opcode);
}
bool X86TargetLowering::isTruncateFree(Type *Ty1, Type *Ty2) const { bool X86TargetLowering::isTruncateFree(Type *Ty1, Type *Ty2) const {
if (!Ty1->isIntegerTy() || !Ty2->isIntegerTy()) if (!Ty1->isIntegerTy() || !Ty2->isIntegerTy())
return false; return false;

3
llvm/lib/Target/X86/X86ISelLowering.h
View File

@ -957,6 +957,9 @@ namespace llvm {
bool isVectorShiftByScalarCheap(Type *Ty) const override; bool isVectorShiftByScalarCheap(Type *Ty) const override;
/// Returns true if the opcode is a commutative binary operation.
bool isCommutativeBinOp(unsigned Opcode) const override;
/// Return true if it's free to truncate a value of /// Return true if it's free to truncate a value of
/// type Ty1 to type Ty2. e.g. On x86 it's free to truncate a i32 value in /// type Ty1 to type Ty2. e.g. On x86 it's free to truncate a i32 value in
/// register EAX to i16 by referencing its sub-register AX. /// register EAX to i16 by referencing its sub-register AX.

2
llvm/test/CodeGen/X86/pmul.ll
View File

@ -1374,9 +1374,9 @@ define <2 x i64> @pmuldq_square(<2 x i64> %x) {
; SSE2-NEXT: punpckldq {{.*#+}} xmm1 = xmm1[0],xmm2[0],xmm1[1],xmm2[1] ; SSE2-NEXT: punpckldq {{.*#+}} xmm1 = xmm1[0],xmm2[0],xmm1[1],xmm2[1]
; SSE2-NEXT: psrlq $32, %xmm0 ; SSE2-NEXT: psrlq $32, %xmm0
; SSE2-NEXT: pmuludq %xmm1, %xmm0 ; SSE2-NEXT: pmuludq %xmm1, %xmm0
; SSE2-NEXT: pmuludq %xmm1, %xmm1
; SSE2-NEXT: paddq %xmm0, %xmm0 ; SSE2-NEXT: paddq %xmm0, %xmm0
; SSE2-NEXT: psllq $32, %xmm0 ; SSE2-NEXT: psllq $32, %xmm0
; SSE2-NEXT: pmuludq %xmm1, %xmm1
; SSE2-NEXT: paddq %xmm1, %xmm0 ; SSE2-NEXT: paddq %xmm1, %xmm0
; SSE2-NEXT: retq ; SSE2-NEXT: retq
; ;