wangtao
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[lldb/ScriptInterpreter] Fix stale/bogus error messages 

Fix the nonsensical error messages for when breakpoint and watchpoint
callbacks are not supported.
This commit is contained in:
Jonas Devlieghere 2019-12-21 22:33:01 -08:00
parent 68cb7d8542
commit ba0eb7b66f
3 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lldb/source/Interpreter/ScriptInterpreter.cpp
View File

@ -32,14 +32,14 @@ void ScriptInterpreter::CollectDataForBreakpointCommandCallback(
CommandReturnObject &result) {
result.SetStatus(eReturnStatusFailed);
result.AppendError(
"ScriptInterpreter::GetScriptCommands(StringList &) is not implemented.");
"This script interpreter does not support breakpoint callbacks.");
}
void ScriptInterpreter::CollectDataForWatchpointCommandCallback(
WatchpointOptions *bp_options, CommandReturnObject &result) {
result.SetStatus(eReturnStatusFailed);
result.AppendError(
"ScriptInterpreter::GetScriptCommands(StringList &) is not implemented.");
"This script interpreter does not support watchpoint callbacks.");
}
std::string ScriptInterpreter::LanguageToString(lldb::ScriptLanguage language) {

5
lldb/test/Shell/ScriptInterpreter/Lua/breakpoint_callback.test Normal file
View File

@ -0,0 +1,5 @@
# REQUIRES: lua
# RUN: %lldb -s %s --script-language lua 2>&1 | FileCheck %s
b main
breakpoint command add -s lua
# CHECK: error: This script interpreter does not support breakpoint callbacks

8
lldb/test/Shell/ScriptInterpreter/Lua/watchpoint_callback.test Normal file
View File

@ -0,0 +1,8 @@
# REQUIRES: lua
# RUN: echo "int main() { return 0; }" | %clang_host -x c - -o %t
# RUN: %lldb -s %s --script-language lua %t 2>&1 | FileCheck %s
b main
r
watchpoint set expr 0x0
watchpoint command add -s lua
# CHECK: error: This script interpreter does not support watchpoint callbacks