wangtao
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't divide-by-zero in RegionStoreManager::getSizeInElements() when getting the size of a VLA. We don't track VLA extents yet, 

but we should at least not crash.  Fixes <rdar://problem/8424269>.

llvm-svn: 113888
This commit is contained in:
Ted Kremenek 2010-09-14 23:08:34 +00:00
parent 8b9126694d
commit c95589d2e6
2 changed files with 35 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
clang/lib/Checker/RegionStore.cpp
View File

@ -745,6 +745,14 @@ DefinedOrUnknownSVal RegionStoreManager::getSizeInElements(const GRState *state,
return UnknownVal();
CharUnits RegionSize = CharUnits::fromQuantity(SizeInt->getSExtValue());
if (Ctx.getAsVariableArrayType(EleTy)) {
// FIXME: We need to track extra state to properly record the size
// of VLAs. Returning UnknownVal here, however, is a stop-gap so that
// we don't have a divide-by-zero below.
return UnknownVal();
}
CharUnits EleSize = Ctx.getTypeSizeInChars(EleTy);
// If a variable is reinterpreted as a type that doesn't fit into a larger

27
clang/test/Analysis/misc-ps-region-store.m
View File

@ -1156,3 +1156,30 @@ pr8141 (void) {
{
}
}
// <rdar://problem/8424269> - Handle looking at the size of a VLA in
// ArrayBoundChecker. Nothing intelligent (yet); just don't crash.
typedef struct RDar8424269_A {
int RDar8424269_C;
} RDar8424269_A;
static void RDar8424269_B(RDar8424269_A *p, unsigned char *RDar8424269_D,
const unsigned char *RDar8424269_E, int RDar8424269_F,
int b_w, int b_h, int dx, int dy) {
int x, y, b, r, l;
unsigned char tmp2t[3][RDar8424269_F * (32 + 8)];
unsigned char *tmp2 = tmp2t[0];
if (p && !p->RDar8424269_C)
b = 15;
tmp2 = tmp2t[1];
if (b & 2) { // expected-warning{{The left operand of '&' is a garbage value}}
for (y = 0; y < b_h; y++) {
for (x = 0; x < b_w + 1; x++) {
int am = 0;
tmp2[x] = am;
}
}
}
tmp2 = tmp2t[2];
}