wangtao
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[llvm-nm] Fix use-after-free for MachOUniversalBinaries 

MachOObjectFile::getHostArch() returns a temporary, and getArchName
returns a StringRef pointing to a temporary std::string.

No tests since it doesn't trigger any errors except with the sanitizers.

llvm-svn: 347230
This commit is contained in:
Francis Visoiu Mistrih 2018-11-19 17:19:50 +00:00
parent 026a2a5152
commit fe034625df
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
llvm/tools/llvm-nm/llvm-nm.cpp
View File

@ -1889,7 +1889,8 @@ static void dumpSymbolNamesFromFile(std::string &Filename) {
// No architecture flags were specified so if this contains a slice that // No architecture flags were specified so if this contains a slice that
// matches the host architecture dump only that. // matches the host architecture dump only that.
if (!ArchAll) { if (!ArchAll) {
StringRef HostArchName = MachOObjectFile::getHostArch().getArchName(); Triple HostTriple = MachOObjectFile::getHostArch();
StringRef HostArchName = HostTriple.getArchName();
for (MachOUniversalBinary::object_iterator I = UB->begin_objects(), for (MachOUniversalBinary::object_iterator I = UB->begin_objects(),
E = UB->end_objects(); E = UB->end_objects();
I != E; ++I) { I != E; ++I) {