llvm-project

Commit Graph

Author	SHA1	Message	Date
Louis Dionne	0a0e0afaa0	[libc++] span: Fix incorrect static asserts The static asserts in span<T, N>::front() and span<T, N>::back() are incorrect as they may be triggered from valid code due to evaluation of a never taken branch: span<int, 0> foo; if (!foo.empty()) { auto x = foo.front(); } The problem is that the branch is always evaluated by the compiler, creating invalid compile errors for span<T, 0>. Thanks to Michael Schellenberger Costa for the patch. Differential Revision: https://reviews.llvm.org/D71995	2020-02-14 14:32:41 +01:00
Casey Carter	132955fa66	Fix occurrences of _LIBCPP_ASSERT in span tests llvm-svn: 357092	2019-03-27 17:03:44 +00:00
Marshall Clow	9ab85a69dc	First part of P1024: Usability Enhancements for std::span. Remove operator() for indexing, and add 'front' and 'back' calls. llvm-svn: 354801	2019-02-25 17:54:08 +00:00

Author

SHA1

Message

Date

Louis Dionne

0a0e0afaa0

[libc++] span: Fix incorrect static asserts

The static asserts in span<T, N>::front() and span<T, N>::back() are
incorrect as they may be triggered from valid code due to evaluation
of a never taken branch:

    span<int, 0> foo;
    if (!foo.empty()) {
        auto x = foo.front();
    }

The problem is that the branch is always evaluated by the compiler,
creating invalid compile errors for span<T, 0>.

Thanks to Michael Schellenberger Costa for the patch.

Differential Revision: https://reviews.llvm.org/D71995

2020-02-14 14:32:41 +01:00

Casey Carter

132955fa66

Fix occurrences of _LIBCPP_ASSERT in span tests

llvm-svn: 357092

2019-03-27 17:03:44 +00:00

Marshall Clow

9ab85a69dc

First part of P1024: Usability Enhancements for std::span. Remove operator() for indexing, and add 'front' and 'back' calls.

llvm-svn: 354801

2019-02-25 17:54:08 +00:00

3 Commits