4 Commits

Author	SHA1	Message	Date
Zachary Turner	59e83892e0	Fix use after free in BinaryStream library. ... This was reported by the ASAN bot, and it turned out to be a fairly fundamental problem with the design of VarStreamArray and the way it passes context information to the extractor. The fix was cumbersome, and I'm not entirely pleased with it, so I plan to revisit this design in the future when I'm not pressed to get the bots green again. For now, this fixes the issue by storing the context information by value instead of by reference, and introduces some impossibly-confusing template magic to make things "work". llvm-svn: 301999	2017-05-03 05:34:00 +00:00
Zachary Turner	e509447418	[Support] Make BinaryStreamArray extractors stateless. ... Instead, we now pass a context memeber through the extraction process. llvm-svn: 301556	2017-04-27 16:11:47 +00:00
Jordan Rose	ca9ca5440e	[unittest] Explicitly specify alignment when using BumpPtrAllocator. ... r297310 began inserting red zones around allocations under ASan, which perturbs the alignment of subsequent allocations. Deliberately specify this in two places where it matters. Fixes failures when these tests are run under ASan and UBSan together. Reviewed by Duncan Exon Smith. rdar://problem/30980047 llvm-svn: 297540	2017-03-11 01:24:56 +00:00
Zachary Turner	d9dc2829ea	[Support] Move Stream library from MSF -> Support. ... After several smaller patches to get most of the core improvements finished up, this patch is a straight move and header fixup of the source. Differential Revision: https://reviews.llvm.org/D30266 llvm-svn: 296810	2017-03-02 20:52:51 +00:00