3 Commits

Author	SHA1	Message	Date
Vedant Kumar	30c1633386	Revert "[Instruction] Add updateLocationAfterHoist helper" ... This reverts commit 4a646ca9e2. This is causing some bots to fail with "!dbg attachment points at wrong subprogram for function", like: http://lab.llvm.org:8011/builders/sanitizer-windows/builds/67958/steps/stage%201%20check/logs/stdio	2020-08-11 14:54:09 -07:00
Vedant Kumar	4a646ca9e2	[Instruction] Add updateLocationAfterHoist helper ... Introduce a helper on Instruction which can be used to update the debug location after hoisting. Use this in GVN and LICM, where we were mistakenly introducing new line 0 locations after hoisting (the docs recommend dropping the location in this case). For more context, see the discussion in https://reviews.llvm.org/D60913. Differential Revision: https://reviews.llvm.org/D85670	2020-08-11 14:05:20 -07:00
Davide Italiano	da52aa2c33	[LICM] When promoting loads to the preheader, drop the location. ... It's really almost going to be misleading, see the example in https://bugs.llvm.org/show_bug.cgi?id=45820 Maybe at some point we can do something fancier, but at least this will fix a bug where we step on dead code while debugging.	2020-05-14 17:05:23 -07:00