llvm-project

Commit Graph

Author	SHA1	Message	Date
Richard Smith	db70052b65	Remove bogus check for template specialization from self-comparison warning. The important check is that we're not within a template instantiation, which we check separately. llvm-svn: 321977	2018-01-07 22:25:55 +00:00
Richard Smith	07c0f285ba	Fix a couple of wrong self-comparison diagnostics. Check whether we are comparing the same entity, not merely the same declaration, and don't assume that weak declarations resolve to distinct entities. llvm-svn: 321976	2018-01-07 22:18:05 +00:00
Eli Friedman	5a722e92af	Add self-comparison warnings for fields. This expands very slightly what -Wtautological-compare considers to be tautological to include implicit accesses to C++ fields and ObjC ivars. I don't want to turn this into a full expression-identity check, but these additions seem pretty well-contained, and maintain the theme of checking for "x == x". <rdar://problem/14431127> llvm-svn: 190118	2013-09-06 03:13:09 +00:00

Author

SHA1

Message

Date

Richard Smith

db70052b65

Remove bogus check for template specialization from self-comparison warning.

The important check is that we're not within a template *instantiation*, which
we check separately.

llvm-svn: 321977

2018-01-07 22:25:55 +00:00

Richard Smith

07c0f285ba

Fix a couple of wrong self-comparison diagnostics.

Check whether we are comparing the same entity, not merely the same
declaration, and don't assume that weak declarations resolve to distinct
entities.

llvm-svn: 321976

2018-01-07 22:18:05 +00:00

Eli Friedman

5a722e92af

Add self-comparison warnings for fields.

This expands very slightly what -Wtautological-compare considers to be
tautological to include implicit accesses to C++ fields and ObjC ivars.
I don't want to turn this into a full expression-identity check, but
these additions seem pretty well-contained, and maintain the theme
of checking for "x == x".

<rdar://problem/14431127>

llvm-svn: 190118

2013-09-06 03:13:09 +00:00

3 Commits