llvm-project

Commit Graph

Author	SHA1	Message	Date
Johannes Doerfert	af52d5a04c	[IPConstantProp][NFCI] Improve and modernize tests Summary: This change is in preparation to reuse these test for the Attributor. It mainly is to remove UB, make it clear what is tested, and use "modern" run lines. Reviewers: fhahn, efriedma, mssimpso, davide Subscribers: bollu, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D69747	2019-12-09 15:24:08 -06:00
Johannes Doerfert	07d16424f2	[Attributor][FIX] Do not try to cast if a cast is not required When we replace constant returns at the call site we did issue a cast in the hopes it would be a no-op if the types are equal. Turns out that is not the case and we have to check it ourselves first. Reused an IPConstantProp test for coverage. No functional change to the test wrt. IPConstantProp.	2019-11-02 00:54:00 -05:00
Craig Topper	6773435624	[IPCP] Bail on extractvalue's with more than 1 index. The replacement code only looks at the first index of the extractvalue. If there are additional indices we'll end up doing a bad replacement. This only happens if the function returns a nested struct. Not sure if clang ever generates such code. The original report came from ispc. Fixes PR43857 Differential Revision: https://reviews.llvm.org/D69656	2019-10-31 10:55:20 -07:00

Author

SHA1

Message

Date

Johannes Doerfert

af52d5a04c

[IPConstantProp][NFCI] Improve and modernize tests

Summary:
This change is in preparation to reuse these test for the Attributor.
It mainly is to remove UB, make it clear what is tested, and use
"modern" run lines.

Reviewers: fhahn, efriedma, mssimpso, davide

Subscribers: bollu, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D69747

2019-12-09 15:24:08 -06:00

Johannes Doerfert

07d16424f2

[Attributor][FIX] Do not try to cast if a cast is not required

When we replace constant returns at the call site we did issue a cast in
the hopes it would be a no-op if the types are equal. Turns out that is
not the case and we have to check it ourselves first.

Reused an IPConstantProp test for coverage. No functional change to the
test wrt. IPConstantProp.

2019-11-02 00:54:00 -05:00

Craig Topper

6773435624

[IPCP] Bail on extractvalue's with more than 1 index.

The replacement code only looks at the first index of the
extractvalue. If there are additional indices we'll end
up doing a bad replacement.

This only happens if the function returns a nested struct. Not
sure if clang ever generates such code. The original report came
from ispc.

Fixes PR43857

Differential Revision: https://reviews.llvm.org/D69656

2019-10-31 10:55:20 -07:00

3 Commits