llvm-project/lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime
Luke Drummond 00f56eebcd cleanup RSCoordinate handling and factor out coordinate parser
- This change updates the signature of
`RenderScriptRuntime::PlaceBreakpointOnKernel` to take a default
RSCoordinate pointer of nullptr. We use this as the predicate value for
the breakpoint coordinate rather than trying to fit a sentinel `-1` into
a signed version.

```
- void
- PlaceBreakpointOnKernel(Stream &strm, const char *name, const std::array<int, 3> coords, Error &error,
- lldb::TargetSP target);
```

```
+ bool
+ PlaceBreakpointOnKernel(lldb::TargetSP target, Stream &messages, const char *name,
+ const lldb_renderscript::RSCoordinate *coords = nullptr);
```
The above change makes the API for setting breakpoints on kernels
cleaner as it returns a failure value rather than modify a sentinel in
the caller. The optional arguments are now last and have a default
(falsey) value.

- RSCoordinate objects are now comparable with operator== and have
  zero initializers which should make them easier to work on.
- Added a `FMT_COORD` macro for use in logging format strings which
  should make format strings a little less verbose.

llvm-svn: 283320
2016-10-05 14:34:52 +00:00
..
CMakeLists.txt [CMake] Fixing a few missing dependencies on intrinsics_gen 2016-10-03 00:03:43 +00:00
RenderScriptExpressionOpts.cpp *** This commit represents a complete reformatting of the LLDB source code 2016-09-06 20:57:50 +00:00
RenderScriptExpressionOpts.h *** This commit represents a complete reformatting of the LLDB source code 2016-09-06 20:57:50 +00:00
RenderScriptRuntime.cpp cleanup RSCoordinate handling and factor out coordinate parser 2016-10-05 14:34:52 +00:00
RenderScriptRuntime.h cleanup RSCoordinate handling and factor out coordinate parser 2016-10-05 14:34:52 +00:00
RenderScriptx86ABIFixups.cpp Fixing a build breakage caused from a change in LLVM rL281019 2016-09-09 10:14:11 +00:00
RenderScriptx86ABIFixups.h *** This commit represents a complete reformatting of the LLDB source code 2016-09-06 20:57:50 +00:00