llvm-project/lldb/test/Shell/SymbolFile/Breakpad
Raphael Isemann 5b354d204d [lldb] Make symbol list output from `image dump symtab` not depend on internal ordering of DenseMap
`image dump symtab` seems to output the symbols in whatever order they appear in
the DenseMap that is used to filter out symbols with non-unique addresses. As
DenseMap is a hash map this order can change at any time so the output of this
command is pretty unstable. This also causes the `Breakpad/symtab.test` to fail
with enabled reverse iteration (which reverses the DenseMap order to find issues
like this).

This patch makes the DenseMap a std::vector and uses a separate DenseSet to do
the address filtering. The output order is now dependent on the order in which
the symbols are read (which should be deterministic). It might also avoid a bit
of work as all the work for creating the Symbol constructor parameters is only
done when we can actually emplace a new Symbol.

Reviewed By: labath

Differential Revision: https://reviews.llvm.org/D87036
2020-09-03 10:27:19 +02:00
..
Inputs [lldb/breakpad] Fix register resolution on arm 2020-03-26 13:51:27 +01:00
line-table-discontinuous-file-ids.test [test] Replace `yaml2obj >` with `yaml2obj -o` and remove unneeded input redirection 2020-08-20 15:01:09 -07:00
line-table-edgecases.test [test] Replace `yaml2obj >` with `yaml2obj -o` and remove unneeded input redirection 2020-08-20 15:01:09 -07:00
line-table-missing-file.test [test] Replace `yaml2obj >` with `yaml2obj -o` and remove unneeded input redirection 2020-08-20 15:01:09 -07:00
line-table-mixed-path-styles.test [test] Replace `yaml2obj >` with `yaml2obj -o` and remove unneeded input redirection 2020-08-20 15:01:09 -07:00
line-table.test [test] Replace `yaml2obj >` with `yaml2obj -o` and remove unneeded input redirection 2020-08-20 15:01:09 -07:00
lit.local.cfg [lldb] add lit.local.cfg for breakpad tests 2020-03-25 17:00:46 +01:00
stack-cfi-arm.yaml [test] Replace `yaml2obj >` with `yaml2obj -o` and remove unneeded input redirection 2020-08-20 15:01:09 -07:00
stack-cfi-parsing.test Update UnwindPlan dump to list if it is a trap handler func; also Command 2020-08-25 20:53:59 -07:00
symtab-macho.test [test] Replace `yaml2obj >` with `yaml2obj -o` and remove unneeded input redirection 2020-08-20 15:01:09 -07:00
symtab.test [lldb] Make symbol list output from `image dump symtab` not depend on internal ordering of DenseMap 2020-09-03 10:27:19 +02:00
unwind-via-raSearch.test Update UnwindPlan dump to list if it is a trap handler func; also Command 2020-08-25 20:53:59 -07:00
unwind-via-stack-cfi.test Update UnwindPlan dump to list if it is a trap handler func; also Command 2020-08-25 20:53:59 -07:00
unwind-via-stack-win-no-memory-info.yaml [test] Replace `yaml2obj >` with `yaml2obj -o` and remove unneeded input redirection 2020-08-20 15:01:09 -07:00
unwind-via-stack-win.test Update UnwindPlan dump to list if it is a trap handler func; also Command 2020-08-25 20:53:59 -07:00