forked from OSchip/llvm-project
742 lines
22 KiB
C++
742 lines
22 KiB
C++
//===--- IdentifierNamingCheck.cpp - clang-tidy ---------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "IdentifierNamingCheck.h"
|
|
|
|
#include "clang/AST/CXXInheritance.h"
|
|
#include "clang/Lex/PPCallbacks.h"
|
|
#include "clang/Lex/Preprocessor.h"
|
|
#include "llvm/ADT/ArrayRef.h"
|
|
#include "llvm/ADT/DenseMapInfo.h"
|
|
#include "llvm/Support/Debug.h"
|
|
#include "llvm/Support/Error.h"
|
|
#include "llvm/Support/Format.h"
|
|
#include "llvm/Support/Regex.h"
|
|
|
|
#define DEBUG_TYPE "clang-tidy"
|
|
|
|
// FixItHint
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang {
|
|
namespace tidy {
|
|
namespace readability {
|
|
|
|
// clang-format off
|
|
#define NAMING_KEYS(m) \
|
|
m(Namespace) \
|
|
m(InlineNamespace) \
|
|
m(EnumConstant) \
|
|
m(ConstexprVariable) \
|
|
m(ConstantMember) \
|
|
m(PrivateMember) \
|
|
m(ProtectedMember) \
|
|
m(PublicMember) \
|
|
m(Member) \
|
|
m(ClassConstant) \
|
|
m(ClassMember) \
|
|
m(GlobalConstant) \
|
|
m(GlobalConstantPointer) \
|
|
m(GlobalPointer) \
|
|
m(GlobalVariable) \
|
|
m(LocalConstant) \
|
|
m(LocalConstantPointer) \
|
|
m(LocalPointer) \
|
|
m(LocalVariable) \
|
|
m(StaticConstant) \
|
|
m(StaticVariable) \
|
|
m(Constant) \
|
|
m(Variable) \
|
|
m(ConstantParameter) \
|
|
m(ParameterPack) \
|
|
m(Parameter) \
|
|
m(PointerParameter) \
|
|
m(ConstantPointerParameter) \
|
|
m(AbstractClass) \
|
|
m(Struct) \
|
|
m(Class) \
|
|
m(Union) \
|
|
m(Enum) \
|
|
m(GlobalFunction) \
|
|
m(ConstexprFunction) \
|
|
m(Function) \
|
|
m(ConstexprMethod) \
|
|
m(VirtualMethod) \
|
|
m(ClassMethod) \
|
|
m(PrivateMethod) \
|
|
m(ProtectedMethod) \
|
|
m(PublicMethod) \
|
|
m(Method) \
|
|
m(Typedef) \
|
|
m(TypeTemplateParameter) \
|
|
m(ValueTemplateParameter) \
|
|
m(TemplateTemplateParameter) \
|
|
m(TemplateParameter) \
|
|
m(TypeAlias) \
|
|
m(MacroDefinition) \
|
|
m(ObjcIvar) \
|
|
|
|
enum StyleKind {
|
|
#define ENUMERATE(v) SK_ ## v,
|
|
NAMING_KEYS(ENUMERATE)
|
|
#undef ENUMERATE
|
|
SK_Count,
|
|
SK_Invalid
|
|
};
|
|
|
|
static StringRef const StyleNames[] = {
|
|
#define STRINGIZE(v) #v,
|
|
NAMING_KEYS(STRINGIZE)
|
|
#undef STRINGIZE
|
|
};
|
|
|
|
#undef NAMING_KEYS
|
|
// clang-format on
|
|
|
|
static constexpr std::pair<StringRef, IdentifierNamingCheck::CaseType>
|
|
Mapping[] = {
|
|
{"aNy_CasE", IdentifierNamingCheck::CT_AnyCase},
|
|
{"lower_case", IdentifierNamingCheck::CT_LowerCase},
|
|
{"UPPER_CASE", IdentifierNamingCheck::CT_UpperCase},
|
|
{"camelBack", IdentifierNamingCheck::CT_CamelBack},
|
|
{"CamelCase", IdentifierNamingCheck::CT_CamelCase},
|
|
{"Camel_Snake_Case", IdentifierNamingCheck::CT_CamelSnakeCase},
|
|
{"camel_Snake_Back", IdentifierNamingCheck::CT_CamelSnakeBack}};
|
|
|
|
namespace {
|
|
/// Callback supplies macros to IdentifierNamingCheck::checkMacro
|
|
class IdentifierNamingCheckPPCallbacks : public PPCallbacks {
|
|
public:
|
|
IdentifierNamingCheckPPCallbacks(Preprocessor *PP,
|
|
IdentifierNamingCheck *Check)
|
|
: PP(PP), Check(Check) {}
|
|
|
|
/// MacroDefined calls checkMacro for macros in the main file
|
|
void MacroDefined(const Token &MacroNameTok,
|
|
const MacroDirective *MD) override {
|
|
Check->checkMacro(PP->getSourceManager(), MacroNameTok, MD->getMacroInfo());
|
|
}
|
|
|
|
/// MacroExpands calls expandMacro for macros in the main file
|
|
void MacroExpands(const Token &MacroNameTok, const MacroDefinition &MD,
|
|
SourceRange /*Range*/,
|
|
const MacroArgs * /*Args*/) override {
|
|
Check->expandMacro(MacroNameTok, MD.getMacroInfo());
|
|
}
|
|
|
|
private:
|
|
Preprocessor *PP;
|
|
IdentifierNamingCheck *Check;
|
|
};
|
|
} // namespace
|
|
|
|
IdentifierNamingCheck::IdentifierNamingCheck(StringRef Name,
|
|
ClangTidyContext *Context)
|
|
: RenamerClangTidyCheck(Name, Context),
|
|
IgnoreFailedSplit(Options.get("IgnoreFailedSplit", false)),
|
|
IgnoreMainLikeFunctions(Options.get("IgnoreMainLikeFunctions", false)) {
|
|
|
|
for (auto const &Name : StyleNames) {
|
|
auto CaseOptional = [&]() -> llvm::Optional<CaseType> {
|
|
auto ValueOr = Options.get((Name + "Case").str(), makeArrayRef(Mapping));
|
|
if (ValueOr)
|
|
return *ValueOr;
|
|
llvm::logAllUnhandledErrors(
|
|
llvm::handleErrors(ValueOr.takeError(),
|
|
[](const MissingOptionError &) -> llvm::Error {
|
|
return llvm::Error::success();
|
|
}),
|
|
llvm::errs(), "warning: ");
|
|
return llvm::None;
|
|
}();
|
|
|
|
auto prefix = Options.get((Name + "Prefix").str(), "");
|
|
auto postfix = Options.get((Name + "Suffix").str(), "");
|
|
|
|
if (CaseOptional || !prefix.empty() || !postfix.empty()) {
|
|
NamingStyles.push_back(NamingStyle(CaseOptional, prefix, postfix));
|
|
} else {
|
|
NamingStyles.push_back(llvm::None);
|
|
}
|
|
}
|
|
}
|
|
|
|
IdentifierNamingCheck::~IdentifierNamingCheck() = default;
|
|
|
|
void IdentifierNamingCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
|
|
for (size_t i = 0; i < SK_Count; ++i) {
|
|
if (NamingStyles[i]) {
|
|
if (NamingStyles[i]->Case) {
|
|
Options.store(Opts, (StyleNames[i] + "Case").str(),
|
|
*NamingStyles[i]->Case, llvm::makeArrayRef(Mapping));
|
|
}
|
|
Options.store(Opts, (StyleNames[i] + "Prefix").str(),
|
|
NamingStyles[i]->Prefix);
|
|
Options.store(Opts, (StyleNames[i] + "Suffix").str(),
|
|
NamingStyles[i]->Suffix);
|
|
}
|
|
}
|
|
|
|
Options.store(Opts, "IgnoreFailedSplit", IgnoreFailedSplit);
|
|
Options.store(Opts, "IgnoreMainLikeFunctions", IgnoreMainLikeFunctions);
|
|
}
|
|
|
|
static bool matchesStyle(StringRef Name,
|
|
IdentifierNamingCheck::NamingStyle Style) {
|
|
static llvm::Regex Matchers[] = {
|
|
llvm::Regex("^.*$"),
|
|
llvm::Regex("^[a-z][a-z0-9_]*$"),
|
|
llvm::Regex("^[a-z][a-zA-Z0-9]*$"),
|
|
llvm::Regex("^[A-Z][A-Z0-9_]*$"),
|
|
llvm::Regex("^[A-Z][a-zA-Z0-9]*$"),
|
|
llvm::Regex("^[A-Z]([a-z0-9]*(_[A-Z])?)*"),
|
|
llvm::Regex("^[a-z]([a-z0-9]*(_[A-Z])?)*"),
|
|
};
|
|
|
|
if (Name.startswith(Style.Prefix))
|
|
Name = Name.drop_front(Style.Prefix.size());
|
|
else
|
|
return false;
|
|
|
|
if (Name.endswith(Style.Suffix))
|
|
Name = Name.drop_back(Style.Suffix.size());
|
|
else
|
|
return false;
|
|
|
|
// Ensure the name doesn't have any extra underscores beyond those specified
|
|
// in the prefix and suffix.
|
|
if (Name.startswith("_") || Name.endswith("_"))
|
|
return false;
|
|
|
|
if (Style.Case && !Matchers[static_cast<size_t>(*Style.Case)].match(Name))
|
|
return false;
|
|
|
|
return true;
|
|
}
|
|
|
|
static std::string fixupWithCase(StringRef Name,
|
|
IdentifierNamingCheck::CaseType Case) {
|
|
static llvm::Regex Splitter(
|
|
"([a-z0-9A-Z]*)(_+)|([A-Z]?[a-z0-9]+)([A-Z]|$)|([A-Z]+)([A-Z]|$)");
|
|
|
|
SmallVector<StringRef, 8> Substrs;
|
|
Name.split(Substrs, "_", -1, false);
|
|
|
|
SmallVector<StringRef, 8> Words;
|
|
for (auto Substr : Substrs) {
|
|
while (!Substr.empty()) {
|
|
SmallVector<StringRef, 8> Groups;
|
|
if (!Splitter.match(Substr, &Groups))
|
|
break;
|
|
|
|
if (Groups[2].size() > 0) {
|
|
Words.push_back(Groups[1]);
|
|
Substr = Substr.substr(Groups[0].size());
|
|
} else if (Groups[3].size() > 0) {
|
|
Words.push_back(Groups[3]);
|
|
Substr = Substr.substr(Groups[0].size() - Groups[4].size());
|
|
} else if (Groups[5].size() > 0) {
|
|
Words.push_back(Groups[5]);
|
|
Substr = Substr.substr(Groups[0].size() - Groups[6].size());
|
|
}
|
|
}
|
|
}
|
|
|
|
if (Words.empty())
|
|
return std::string(Name);
|
|
|
|
std::string Fixup;
|
|
switch (Case) {
|
|
case IdentifierNamingCheck::CT_AnyCase:
|
|
Fixup += Name;
|
|
break;
|
|
|
|
case IdentifierNamingCheck::CT_LowerCase:
|
|
for (auto const &Word : Words) {
|
|
if (&Word != &Words.front())
|
|
Fixup += "_";
|
|
Fixup += Word.lower();
|
|
}
|
|
break;
|
|
|
|
case IdentifierNamingCheck::CT_UpperCase:
|
|
for (auto const &Word : Words) {
|
|
if (&Word != &Words.front())
|
|
Fixup += "_";
|
|
Fixup += Word.upper();
|
|
}
|
|
break;
|
|
|
|
case IdentifierNamingCheck::CT_CamelCase:
|
|
for (auto const &Word : Words) {
|
|
Fixup += Word.substr(0, 1).upper();
|
|
Fixup += Word.substr(1).lower();
|
|
}
|
|
break;
|
|
|
|
case IdentifierNamingCheck::CT_CamelBack:
|
|
for (auto const &Word : Words) {
|
|
if (&Word == &Words.front()) {
|
|
Fixup += Word.lower();
|
|
} else {
|
|
Fixup += Word.substr(0, 1).upper();
|
|
Fixup += Word.substr(1).lower();
|
|
}
|
|
}
|
|
break;
|
|
|
|
case IdentifierNamingCheck::CT_CamelSnakeCase:
|
|
for (auto const &Word : Words) {
|
|
if (&Word != &Words.front())
|
|
Fixup += "_";
|
|
Fixup += Word.substr(0, 1).upper();
|
|
Fixup += Word.substr(1).lower();
|
|
}
|
|
break;
|
|
|
|
case IdentifierNamingCheck::CT_CamelSnakeBack:
|
|
for (auto const &Word : Words) {
|
|
if (&Word != &Words.front()) {
|
|
Fixup += "_";
|
|
Fixup += Word.substr(0, 1).upper();
|
|
} else {
|
|
Fixup += Word.substr(0, 1).lower();
|
|
}
|
|
Fixup += Word.substr(1).lower();
|
|
}
|
|
break;
|
|
}
|
|
|
|
return Fixup;
|
|
}
|
|
|
|
static bool isParamInMainLikeFunction(const ParmVarDecl &ParmDecl,
|
|
bool IncludeMainLike) {
|
|
const auto *FDecl =
|
|
dyn_cast_or_null<FunctionDecl>(ParmDecl.getParentFunctionOrMethod());
|
|
if (!FDecl)
|
|
return false;
|
|
if (FDecl->isMain())
|
|
return true;
|
|
if (!IncludeMainLike)
|
|
return false;
|
|
if (FDecl->getAccess() != AS_public && FDecl->getAccess() != AS_none)
|
|
return false;
|
|
enum MainType { None, Main, WMain };
|
|
auto IsCharPtrPtr = [](QualType QType) -> MainType {
|
|
if (QType.isNull())
|
|
return None;
|
|
if (QType = QType->getPointeeType(), QType.isNull())
|
|
return None;
|
|
if (QType = QType->getPointeeType(), QType.isNull())
|
|
return None;
|
|
if (QType->isCharType())
|
|
return Main;
|
|
if (QType->isWideCharType())
|
|
return WMain;
|
|
return None;
|
|
};
|
|
auto IsIntType = [](QualType QType) {
|
|
if (QType.isNull())
|
|
return false;
|
|
if (const auto *Builtin =
|
|
dyn_cast<BuiltinType>(QType->getUnqualifiedDesugaredType())) {
|
|
return Builtin->getKind() == BuiltinType::Int;
|
|
}
|
|
return false;
|
|
};
|
|
if (!IsIntType(FDecl->getReturnType()))
|
|
return false;
|
|
if (FDecl->getNumParams() < 2 || FDecl->getNumParams() > 3)
|
|
return false;
|
|
if (!IsIntType(FDecl->parameters()[0]->getType()))
|
|
return false;
|
|
MainType Type = IsCharPtrPtr(FDecl->parameters()[1]->getType());
|
|
if (Type == None)
|
|
return false;
|
|
if (FDecl->getNumParams() == 3 &&
|
|
IsCharPtrPtr(FDecl->parameters()[2]->getType()) != Type)
|
|
return false;
|
|
|
|
if (Type == Main) {
|
|
static llvm::Regex Matcher(
|
|
"(^[Mm]ain([_A-Z]|$))|([a-z0-9_]Main([_A-Z]|$))|(_main(_|$))");
|
|
assert(Matcher.isValid() && "Invalid Matcher for main like functions.");
|
|
return Matcher.match(FDecl->getName());
|
|
} else {
|
|
static llvm::Regex Matcher("(^((W[Mm])|(wm))ain([_A-Z]|$))|([a-z0-9_]W[Mm]"
|
|
"ain([_A-Z]|$))|(_wmain(_|$))");
|
|
assert(Matcher.isValid() && "Invalid Matcher for wmain like functions.");
|
|
return Matcher.match(FDecl->getName());
|
|
}
|
|
}
|
|
|
|
static std::string
|
|
fixupWithStyle(StringRef Name,
|
|
const IdentifierNamingCheck::NamingStyle &Style) {
|
|
const std::string Fixed = fixupWithCase(
|
|
Name, Style.Case.getValueOr(IdentifierNamingCheck::CaseType::CT_AnyCase));
|
|
StringRef Mid = StringRef(Fixed).trim("_");
|
|
if (Mid.empty())
|
|
Mid = "_";
|
|
return (Style.Prefix + Mid + Style.Suffix).str();
|
|
}
|
|
|
|
static StyleKind findStyleKind(
|
|
const NamedDecl *D,
|
|
const std::vector<llvm::Optional<IdentifierNamingCheck::NamingStyle>>
|
|
&NamingStyles,
|
|
bool IgnoreMainLikeFunctions) {
|
|
assert(D && D->getIdentifier() && !D->getName().empty() && !D->isImplicit() &&
|
|
"Decl must be an explicit identifier with a name.");
|
|
|
|
if (isa<ObjCIvarDecl>(D) && NamingStyles[SK_ObjcIvar])
|
|
return SK_ObjcIvar;
|
|
|
|
if (isa<TypedefDecl>(D) && NamingStyles[SK_Typedef])
|
|
return SK_Typedef;
|
|
|
|
if (isa<TypeAliasDecl>(D) && NamingStyles[SK_TypeAlias])
|
|
return SK_TypeAlias;
|
|
|
|
if (const auto *Decl = dyn_cast<NamespaceDecl>(D)) {
|
|
if (Decl->isAnonymousNamespace())
|
|
return SK_Invalid;
|
|
|
|
if (Decl->isInline() && NamingStyles[SK_InlineNamespace])
|
|
return SK_InlineNamespace;
|
|
|
|
if (NamingStyles[SK_Namespace])
|
|
return SK_Namespace;
|
|
}
|
|
|
|
if (isa<EnumDecl>(D) && NamingStyles[SK_Enum])
|
|
return SK_Enum;
|
|
|
|
if (isa<EnumConstantDecl>(D)) {
|
|
if (NamingStyles[SK_EnumConstant])
|
|
return SK_EnumConstant;
|
|
|
|
if (NamingStyles[SK_Constant])
|
|
return SK_Constant;
|
|
|
|
return SK_Invalid;
|
|
}
|
|
|
|
if (const auto *Decl = dyn_cast<CXXRecordDecl>(D)) {
|
|
if (Decl->isAnonymousStructOrUnion())
|
|
return SK_Invalid;
|
|
|
|
if (!Decl->getCanonicalDecl()->isThisDeclarationADefinition())
|
|
return SK_Invalid;
|
|
|
|
if (Decl->hasDefinition() && Decl->isAbstract() &&
|
|
NamingStyles[SK_AbstractClass])
|
|
return SK_AbstractClass;
|
|
|
|
if (Decl->isStruct() && NamingStyles[SK_Struct])
|
|
return SK_Struct;
|
|
|
|
if (Decl->isStruct() && NamingStyles[SK_Class])
|
|
return SK_Class;
|
|
|
|
if (Decl->isClass() && NamingStyles[SK_Class])
|
|
return SK_Class;
|
|
|
|
if (Decl->isClass() && NamingStyles[SK_Struct])
|
|
return SK_Struct;
|
|
|
|
if (Decl->isUnion() && NamingStyles[SK_Union])
|
|
return SK_Union;
|
|
|
|
if (Decl->isEnum() && NamingStyles[SK_Enum])
|
|
return SK_Enum;
|
|
|
|
return SK_Invalid;
|
|
}
|
|
|
|
if (const auto *Decl = dyn_cast<FieldDecl>(D)) {
|
|
QualType Type = Decl->getType();
|
|
|
|
if (!Type.isNull() && Type.isConstQualified()) {
|
|
if (NamingStyles[SK_ConstantMember])
|
|
return SK_ConstantMember;
|
|
|
|
if (NamingStyles[SK_Constant])
|
|
return SK_Constant;
|
|
}
|
|
|
|
if (Decl->getAccess() == AS_private && NamingStyles[SK_PrivateMember])
|
|
return SK_PrivateMember;
|
|
|
|
if (Decl->getAccess() == AS_protected && NamingStyles[SK_ProtectedMember])
|
|
return SK_ProtectedMember;
|
|
|
|
if (Decl->getAccess() == AS_public && NamingStyles[SK_PublicMember])
|
|
return SK_PublicMember;
|
|
|
|
if (NamingStyles[SK_Member])
|
|
return SK_Member;
|
|
|
|
return SK_Invalid;
|
|
}
|
|
|
|
if (const auto *Decl = dyn_cast<ParmVarDecl>(D)) {
|
|
if (isParamInMainLikeFunction(*Decl, IgnoreMainLikeFunctions))
|
|
return SK_Invalid;
|
|
QualType Type = Decl->getType();
|
|
|
|
if (Decl->isConstexpr() && NamingStyles[SK_ConstexprVariable])
|
|
return SK_ConstexprVariable;
|
|
|
|
if (!Type.isNull() && Type.isConstQualified()) {
|
|
if (Type.getTypePtr()->isAnyPointerType() && NamingStyles[SK_ConstantPointerParameter])
|
|
return SK_ConstantPointerParameter;
|
|
|
|
if (NamingStyles[SK_ConstantParameter])
|
|
return SK_ConstantParameter;
|
|
|
|
if (NamingStyles[SK_Constant])
|
|
return SK_Constant;
|
|
}
|
|
|
|
if (Decl->isParameterPack() && NamingStyles[SK_ParameterPack])
|
|
return SK_ParameterPack;
|
|
|
|
if (!Type.isNull() && Type.getTypePtr()->isAnyPointerType() && NamingStyles[SK_PointerParameter])
|
|
return SK_PointerParameter;
|
|
|
|
if (NamingStyles[SK_Parameter])
|
|
return SK_Parameter;
|
|
|
|
return SK_Invalid;
|
|
}
|
|
|
|
if (const auto *Decl = dyn_cast<VarDecl>(D)) {
|
|
QualType Type = Decl->getType();
|
|
|
|
if (Decl->isConstexpr() && NamingStyles[SK_ConstexprVariable])
|
|
return SK_ConstexprVariable;
|
|
|
|
if (!Type.isNull() && Type.isConstQualified()) {
|
|
if (Decl->isStaticDataMember() && NamingStyles[SK_ClassConstant])
|
|
return SK_ClassConstant;
|
|
|
|
if (Decl->isFileVarDecl() && Type.getTypePtr()->isAnyPointerType() && NamingStyles[SK_GlobalConstantPointer])
|
|
return SK_GlobalConstantPointer;
|
|
|
|
if (Decl->isFileVarDecl() && NamingStyles[SK_GlobalConstant])
|
|
return SK_GlobalConstant;
|
|
|
|
if (Decl->isStaticLocal() && NamingStyles[SK_StaticConstant])
|
|
return SK_StaticConstant;
|
|
|
|
if (Decl->isLocalVarDecl() && Type.getTypePtr()->isAnyPointerType() && NamingStyles[SK_LocalConstantPointer])
|
|
return SK_LocalConstantPointer;
|
|
|
|
if (Decl->isLocalVarDecl() && NamingStyles[SK_LocalConstant])
|
|
return SK_LocalConstant;
|
|
|
|
if (Decl->isFunctionOrMethodVarDecl() && NamingStyles[SK_LocalConstant])
|
|
return SK_LocalConstant;
|
|
|
|
if (NamingStyles[SK_Constant])
|
|
return SK_Constant;
|
|
}
|
|
|
|
if (Decl->isStaticDataMember() && NamingStyles[SK_ClassMember])
|
|
return SK_ClassMember;
|
|
|
|
if (Decl->isFileVarDecl() && Type.getTypePtr()->isAnyPointerType() && NamingStyles[SK_GlobalPointer])
|
|
return SK_GlobalPointer;
|
|
|
|
if (Decl->isFileVarDecl() && NamingStyles[SK_GlobalVariable])
|
|
return SK_GlobalVariable;
|
|
|
|
if (Decl->isStaticLocal() && NamingStyles[SK_StaticVariable])
|
|
return SK_StaticVariable;
|
|
|
|
if (Decl->isLocalVarDecl() && Type.getTypePtr()->isAnyPointerType() && NamingStyles[SK_LocalPointer])
|
|
return SK_LocalPointer;
|
|
|
|
if (Decl->isLocalVarDecl() && NamingStyles[SK_LocalVariable])
|
|
return SK_LocalVariable;
|
|
|
|
if (Decl->isFunctionOrMethodVarDecl() && NamingStyles[SK_LocalVariable])
|
|
return SK_LocalVariable;
|
|
|
|
if (NamingStyles[SK_Variable])
|
|
return SK_Variable;
|
|
|
|
return SK_Invalid;
|
|
}
|
|
|
|
if (const auto *Decl = dyn_cast<CXXMethodDecl>(D)) {
|
|
if (Decl->isMain() || !Decl->isUserProvided() ||
|
|
Decl->size_overridden_methods() > 0)
|
|
return SK_Invalid;
|
|
|
|
// If this method has the same name as any base method, this is likely
|
|
// necessary even if it's not an override. e.g. CRTP.
|
|
auto FindHidden = [&](const CXXBaseSpecifier *S, clang::CXXBasePath &P) {
|
|
return CXXRecordDecl::FindOrdinaryMember(S, P, Decl->getDeclName());
|
|
};
|
|
CXXBasePaths UnusedPaths;
|
|
if (Decl->getParent()->lookupInBases(FindHidden, UnusedPaths))
|
|
return SK_Invalid;
|
|
|
|
if (Decl->isConstexpr() && NamingStyles[SK_ConstexprMethod])
|
|
return SK_ConstexprMethod;
|
|
|
|
if (Decl->isConstexpr() && NamingStyles[SK_ConstexprFunction])
|
|
return SK_ConstexprFunction;
|
|
|
|
if (Decl->isStatic() && NamingStyles[SK_ClassMethod])
|
|
return SK_ClassMethod;
|
|
|
|
if (Decl->isVirtual() && NamingStyles[SK_VirtualMethod])
|
|
return SK_VirtualMethod;
|
|
|
|
if (Decl->getAccess() == AS_private && NamingStyles[SK_PrivateMethod])
|
|
return SK_PrivateMethod;
|
|
|
|
if (Decl->getAccess() == AS_protected && NamingStyles[SK_ProtectedMethod])
|
|
return SK_ProtectedMethod;
|
|
|
|
if (Decl->getAccess() == AS_public && NamingStyles[SK_PublicMethod])
|
|
return SK_PublicMethod;
|
|
|
|
if (NamingStyles[SK_Method])
|
|
return SK_Method;
|
|
|
|
if (NamingStyles[SK_Function])
|
|
return SK_Function;
|
|
|
|
return SK_Invalid;
|
|
}
|
|
|
|
if (const auto *Decl = dyn_cast<FunctionDecl>(D)) {
|
|
if (Decl->isMain())
|
|
return SK_Invalid;
|
|
|
|
if (Decl->isConstexpr() && NamingStyles[SK_ConstexprFunction])
|
|
return SK_ConstexprFunction;
|
|
|
|
if (Decl->isGlobal() && NamingStyles[SK_GlobalFunction])
|
|
return SK_GlobalFunction;
|
|
|
|
if (NamingStyles[SK_Function])
|
|
return SK_Function;
|
|
}
|
|
|
|
if (isa<TemplateTypeParmDecl>(D)) {
|
|
if (NamingStyles[SK_TypeTemplateParameter])
|
|
return SK_TypeTemplateParameter;
|
|
|
|
if (NamingStyles[SK_TemplateParameter])
|
|
return SK_TemplateParameter;
|
|
|
|
return SK_Invalid;
|
|
}
|
|
|
|
if (isa<NonTypeTemplateParmDecl>(D)) {
|
|
if (NamingStyles[SK_ValueTemplateParameter])
|
|
return SK_ValueTemplateParameter;
|
|
|
|
if (NamingStyles[SK_TemplateParameter])
|
|
return SK_TemplateParameter;
|
|
|
|
return SK_Invalid;
|
|
}
|
|
|
|
if (isa<TemplateTemplateParmDecl>(D)) {
|
|
if (NamingStyles[SK_TemplateTemplateParameter])
|
|
return SK_TemplateTemplateParameter;
|
|
|
|
if (NamingStyles[SK_TemplateParameter])
|
|
return SK_TemplateParameter;
|
|
|
|
return SK_Invalid;
|
|
}
|
|
|
|
return SK_Invalid;
|
|
}
|
|
|
|
llvm::Optional<RenamerClangTidyCheck::FailureInfo>
|
|
IdentifierNamingCheck::GetDeclFailureInfo(const NamedDecl *Decl,
|
|
const SourceManager &SM) const {
|
|
StyleKind SK = findStyleKind(Decl, NamingStyles, IgnoreMainLikeFunctions);
|
|
if (SK == SK_Invalid)
|
|
return None;
|
|
|
|
if (!NamingStyles[SK])
|
|
return None;
|
|
|
|
const NamingStyle &Style = *NamingStyles[SK];
|
|
StringRef Name = Decl->getName();
|
|
if (matchesStyle(Name, Style))
|
|
return None;
|
|
|
|
std::string KindName = fixupWithCase(StyleNames[SK], CT_LowerCase);
|
|
std::replace(KindName.begin(), KindName.end(), '_', ' ');
|
|
|
|
std::string Fixup = fixupWithStyle(Name, Style);
|
|
if (StringRef(Fixup).equals(Name)) {
|
|
if (!IgnoreFailedSplit) {
|
|
LLVM_DEBUG(llvm::dbgs()
|
|
<< Decl->getBeginLoc().printToString(SM)
|
|
<< llvm::format(": unable to split words for %s '%s'\n",
|
|
KindName.c_str(), Name.str().c_str()));
|
|
}
|
|
return None;
|
|
}
|
|
return FailureInfo{std::move(KindName), std::move(Fixup)};
|
|
}
|
|
|
|
llvm::Optional<RenamerClangTidyCheck::FailureInfo>
|
|
IdentifierNamingCheck::GetMacroFailureInfo(const Token &MacroNameTok,
|
|
const SourceManager &SM) const {
|
|
if (!NamingStyles[SK_MacroDefinition])
|
|
return None;
|
|
|
|
StringRef Name = MacroNameTok.getIdentifierInfo()->getName();
|
|
const NamingStyle &Style = *NamingStyles[SK_MacroDefinition];
|
|
if (matchesStyle(Name, Style))
|
|
return None;
|
|
|
|
std::string KindName =
|
|
fixupWithCase(StyleNames[SK_MacroDefinition], CT_LowerCase);
|
|
std::replace(KindName.begin(), KindName.end(), '_', ' ');
|
|
|
|
std::string Fixup = fixupWithStyle(Name, Style);
|
|
if (StringRef(Fixup).equals(Name)) {
|
|
if (!IgnoreFailedSplit) {
|
|
LLVM_DEBUG(llvm::dbgs()
|
|
<< MacroNameTok.getLocation().printToString(SM)
|
|
<< llvm::format(": unable to split words for %s '%s'\n",
|
|
KindName.c_str(), Name.str().c_str()));
|
|
}
|
|
return None;
|
|
}
|
|
return FailureInfo{std::move(KindName), std::move(Fixup)};
|
|
}
|
|
|
|
RenamerClangTidyCheck::DiagInfo
|
|
IdentifierNamingCheck::GetDiagInfo(const NamingCheckId &ID,
|
|
const NamingCheckFailure &Failure) const {
|
|
return DiagInfo{"invalid case style for %0 '%1'",
|
|
[&](DiagnosticBuilder &diag) {
|
|
diag << Failure.Info.KindName << ID.second;
|
|
}};
|
|
}
|
|
|
|
} // namespace readability
|
|
} // namespace tidy
|
|
} // namespace clang
|