OSchip
/
llvm-project
mirror of https://github.com/THU-DSP-LAB/llvm-project.git
13
0
Fork 6
Code Issues Packages Projects Releases Wiki Activity

[libc] disable flakey tests 

The mprotect test has been failing and causing significant buildbot
noise. Given that this is a simple functions it's more important that
the buildbot errors be useful than having more thorough tests for this
function.

Reviewed By: sivachandra, lntue

Differential Revision: https://reviews.llvm.org/D138061
This commit is contained in:
Michael Jones 2022-11-15 13:50:27 -08:00
parent 0e1708ff64
commit c46a465eb9
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libc/test/src/sys/mman/linux/mprotect_test.cpp
View File

@ -43,6 +43,9 @@ TEST(LlvmLibcMProtectTest, NoError) {
EXPECT_THAT(__llvm_libc::munmap(addr, alloc_size), Succeeds()); EXPECT_THAT(__llvm_libc::munmap(addr, alloc_size), Succeeds());
} }
// This test is disabled currently due to flakeyness. It will be re-enabled once
// it is less flakey.
/*
TEST(LlvmLibcMProtectTest, Error_InvalidWrite) { TEST(LlvmLibcMProtectTest, Error_InvalidWrite) {
// attempting to write to a read-only protected part of memory should cause a // attempting to write to a read-only protected part of memory should cause a
// segfault. // segfault.
@ -60,3 +63,4 @@ TEST(LlvmLibcMProtectTest, Error_InvalidWrite) {
// Reading from a write only segment may succeed on some platforms, so there's // Reading from a write only segment may succeed on some platforms, so there's
// no test to check that. // no test to check that.
} }
*/