![]() This is analogous to D86156 (which preserves "lossy" BFI in loop passes). Lossy means that the analysis preserved may not be up to date with regards to new blocks that are added in loop passes, but BPI will not contain stale pointers to basic blocks that are deleted by the loop passes. This is achieved through BasicBlockCallbackVH in BPI, which calls eraseBlock that updates the data structures in BPI whenever a basic block is deleted. This patch does not have any changes in the upstream pipeline, since none of the loop passes in the pipeline use BPI currently. However, since BPI wasn't previously preserved in loop passes, the loop predication pass was invoking BPI *on the entire function* every time it ran in an LPM. This caused massive compile time in our downstream LPM invocation which contained loop predication. See updated test with an invocation of a loop-pipeline containing loop predication and -debug-pass turned ON. Reviewed-By: asbirlea, modimo Differential Revision: https://reviews.llvm.org/D110438 |
||
---|---|---|
.. | ||
basic.ll | ||
basic_widenable_branch_guards.ll | ||
invalidate-analyses.ll | ||
invariant_load.ll | ||
nested.ll | ||
predicate-exits.ll | ||
preserve-bpi.ll | ||
profitability.ll | ||
reverse.ll | ||
unswitch-exit-loop.ll | ||
visited.ll | ||
widened.ll |