When the module is compiled with `MODULE` (the default), the proper linker flags are added on macOS (specifically `-undefined dynamic_lookup`). Otherwise, `rclpy` segfaults when linked on conda.
Is the `SHARED` really necessary? The `pybind11` documentation says:
> Specifying `SHARED` will create a more traditional dynamic library which can also be linked from elsewhere.
Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com>
(cherry picked from commit 7fb093ba17)
Co-authored-by: Wolf Vollprecht <w.vollprecht@gmail.com>
They are both outdated and both no longer serving their
intended purpose.
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 78f5e14cda)
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Closes rclpy:#1313
Current if spin_unitl_future_complete is called inside a nodes callback it removes the node from the executor
This results in any subsiquent waitables to never be checked by the node since the node is no longer in the executor
This aims to fix that by only removing the node from the executor if it wasn't already present
Signed-off-by: Jonathan Blixt <jmblixt3@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 47346ef968)
Co-authored-by: Jonathan <jmblixt3@gmail.com>
We were fetching one more lifecycle transition than existed
in the source list (i.e. we should use < instead of <=).
In turn, this allows us to enable the test_lifecycle.py test,
and to fix the spurious "empty" string in the expected states.
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 2a8f23ed1b)
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
* Start typing time.py
* Testing out Enum wrapper for ClockType
* convert to rcl_clock_type_t
* Update create_time_point
* add types to logging_service
* Add types to duration.py
* Add newlines for class definintions
* update type alias name
* Update to use Protocols
* Add types to time.py
* Add types
* Fix import order
* Started typing clock.py
* Move typealias import
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc170@case.edu>
Newer versions of flake8 complain that using 'str' as a
variable shadows a builtin. Just make it 's'.
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
* Start typing time.py
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Testing out Enum wrapper for ClockType
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* convert to rcl_clock_type_t
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Undo Change to time_point.cpp
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Update create_time_point
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Lint fixes
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Add debug message
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Remove test file
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Try extending the type assert
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Add types to logging_service.py (#1227)
* add types to logging_service
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Add types to duration.py
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Add newlines for class definintions
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* update type alias name
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Remove newline
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Merge?
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Fix failed merge
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Update to use Protocols
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Fix import error
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Add types to time.py
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Linty
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
---------
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Add types to TypeHash and moved away from __slots__ usage
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* remove docstring types
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
---------
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Add types to validate files
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* remove type annotations from docstrings
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* removed other type annotated docstrings
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
---------
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Add types to logging_service.py (#1227)
* add types to logging_service
* Add types to duration.py
* Add newlines for class definintions
* update type alias name
* Update to use Protocols
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Add types to logging.py
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Using LoggingSeverity Enum over int
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Add type Union of int and LoggingSeverity because set_logger_level seems like it could take ints
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Switch to Union over | for python 3.8 support
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* add return types
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
---------
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Marco A. Gutierrez