* Various typing fixes
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Parameter narrowing in node.py
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Update tuple[None, None] narrowing in actio clients and services
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Flake8 fixes in service_instrospection.pyi
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
---------
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Add types to Action objects
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* fix inheritance order
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* move type into string
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* string around type
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* missed string type
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* switch to 2 arg generics for clients/services
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* move import into TYPE_CHECKING block
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Type over type
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Add ClassVar
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Hopefully fix rhel failure
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* re-run CI
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* re-run CI
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Fix import
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Delete .vscode/settings.json
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Update client.py
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
---------
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Add types to wait_for_message.py
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Add copyright
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* re-run CI
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* re-run CI
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* move Handles into _rclpy_pybind11
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Move Handles into type stubs:
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Move Handles into type stubs
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* move [] into string
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* fix imports
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* remove extra line
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* puy _rclpy.Publisher in quotes
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* fix capitalization
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Add EventHandle Constructor
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Use RuntimeError for context
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Add TYPE_CHECKING import
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* init
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* stash
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* more progress
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* done
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* move type into string
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* rclpy.impl
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* spelling error and type in string
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* type in string
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Narrow Task[] type
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* remove if statements around nodes_to_use
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Change Generic Srv/Cli
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Update rclpy/rclpy/executors.py
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* EntityT cleanup
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Fix Optional goof
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* remove SrvEventT
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Only 2 args for srv/client
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* fix Callable[]
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
---------
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
* Add types to wait_for_message.py
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Add copyright
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* re-run CI
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* re-run CI
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* move Handles into _rclpy_pybind11
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Move Handles into type stubs:
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Move Handles into type stubs
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* move [] into string
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* fix imports
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* remove extra line
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* puy _rclpy.Publisher in quotes
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* fix capitalization
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Add EventHandle Constructor
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Use RuntimeError for context
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Add TYPE_CHECKING import
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* init
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* remove .vscode file
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* move into string
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* fix flake8
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
---------
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Add support for operator overloading of `Duration`
This PR adds support for operator overloading of the `Duration` class in
python. This should improve the overall UX of the rclpy library.
---------
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
* Init types
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* add typealias
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* re-run ci
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* re-run ci
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* re-run ci
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* re-run ci
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
---------
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Client:call generates TimeoutError exception when it is timed out.
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
* call Thread.is_alive() to make sure the thread has started.
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
---------
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
* Fix the race condition while calling rcl_shutdown
Signed-off-by: Barry Xu <barry.xu@sony.com>
* Avoid calling rcl_shutdown() multiple times on the same context
Signed-off-by: Barry Xu <barry.xu@sony.com>
* Multiple calls to Context::shutdown will throw an exception
Signed-off-by: Barry Xu <barry.xu@sony.com>
* Update the name of an exception
Signed-off-by: Barry Xu <barry.xu@sony.com>
---------
Signed-off-by: Barry Xu <barry.xu@sony.com>
* Stop using python_cmake_module.
We really don't need it anymore, and can just use the
builtin find_package(Python3).
* Set hints to find the python version we actually want.
The comment in the commit explains the reasoning behind it.
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
* Add types to parameter_client.py
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* remove extra Future
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
---------
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Add types
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* string around type
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* string around type
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* use error
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* flake8
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* switch error raise order
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* unify error
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
---------
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Closes rclpy:#1313
Current if spin_unitl_future_complete is called inside a nodes callback it removes the node from the executor
This results in any subsiquent waitables to never be checked by the node since the node is no longer in the executor
This aims to fix that by only removing the node from the executor if it wasn't already present
Signed-off-by: Jonathan Blixt <jmblixt3@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Add types to wait_for_message.py
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Add copyright
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* re-run CI
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* re-run CI
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* move Handles into _rclpy_pybind11
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Move Handles into type stubs:
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Move Handles into type stubs
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* move [] into string
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* fix imports
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* remove extra line
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* puy _rclpy.Publisher in quotes
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* fix capitalization
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Add EventHandle Constructor
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Use RuntimeError for context
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Add TYPE_CHECKING import
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
---------
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Replace rclpyHandle with stubs
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Rerun CI
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Rerun CI
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
---------
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Co-authored-by: Shane Loretz <sloretz@intrinsic.ai>
* Add types to qos.py
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Add missing default value
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* TypeAlias 3.8
Signed-off-by: Michael Carlstrom <rmc170@case.edu>
* Flake8 fixes and simplification
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Fix depth=0 error
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Fix depth=0 error
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* combine error message
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* revert to is None
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* revert to is None
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Fix 0 falsey
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* flip self.depth
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* replace or with ternary
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
---------
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc170@case.edu>
Co-authored-by: Shane Loretz <sloretz@intrinsic.ai>
Yadunund